thunder-project / thunder

scalable analysis of images and time series
http://thunder-project.org
Apache License 2.0
814 stars 184 forks source link

'auto' for block_size on series.toimages #355

Closed jwittenbach closed 8 years ago

jwittenbach commented 8 years ago

Closes #353

jwittenbach commented 8 years ago

Verified that this fixes the problem that @boazmohar mentioned in #353 -- now calling Series.toimages with the default chunk_size produces a reasonable number of partitions in the resulting Images object. In particular, if the number of pixels is equal to the number of time points ("square matrix"), then Images.toseries and Series.toimages produce objects with the same number of partitions.

freeman-lab commented 8 years ago

Nice fix @jwittenbach , and good job working through the issue @boazmohar ! Seems like a great solution.

jwittenbach commented 8 years ago

Thanks @freeman-lab! Merging this in.