search

thunderace / Esp8266-Arduino-Makefile

Makefile to build arduino code for ESP8266/ESP32x under linux (tested on debian X64)
34 stars 20 forks source link

Mac OS compatibility fixes #11

Closed ahihi closed 6 years ago

ahihi commented 6 years ago

Hi,

This patch allows the makefile to work on Mac OS. (10.10 tested)

I believe the changes retain compatibility with Linux & Windows, but can't test those myself.

thunderace commented 6 years ago

Thx for your help. For now, I can't test your modifications on Windows so i can't merge.

ahihi commented 6 years ago

I understand. I'll try to find some time to set up a Cygwin system and try it. :)

thunderace commented 6 years ago

Manual merge of you PR (except for the SIZE_REGEX modification).

Tested on CYGWIN and LINUX.

Thx for your help

ahihi commented 6 years ago

Ah, did the new SIZE_REGEX cause issues? I changed it because Mac OS grep fails with "empty (sub)expression" on (foo|). It's a weird quirk, different from even FreeBSD…

thunderace commented 6 years ago

No issue but the SIZE_REGEX come directly from the platform.txt of the ESP8266 Arduino SDK (with the ending |). I will test your modification on others platforms.

thunderace commented 6 years ago

It's OK : the trailing | is removed for ESP8266 and ESP32