search

thunderbird-conversations / thunderbird-conversations

An extension for Thunderbird that allows you to view threads as "real" conversations, including your own emails. This extension also adds a bunch of useful UI features in the conversation view.
https://github.com/thunderbird-conversations/thunderbird-conversations/wiki
Mozilla Public License 2.0
654 stars 108 forks source link

Make `quoting.js` less destructive #1435

Open siefkenj opened 4 years ago

siefkenj commented 4 years ago

quoting.js seems to modify the DOM of the message iframe directly, which makes it hard to test and revert if an error is thrown. I'm no sure how much DOM manipulation conversations does, but I would propose a function that inputs a document fragment and returns a new document fragment with the blockquote and then replacing the body of the iframe instead of modifying it directly. This could also lead to a "turn off smart formatting" option.

There are also various comments around quoting.js that say it almost never works. Are these heuristics worth including? Do newer Yahoo and Hotmail messages have more predictable quoting?

Standard8 commented 3 years ago

@siefkenj I think you've done this now, or is there more to do?

siefkenj commented 3 years ago

Yes and no...the capability is there, but its still being used in a destructive way.