thunderbird / addons-server

🕶 addons.thunderbird.net Django app and API, forked from addons.mozilla.org 🎉
https://addons.thunderbird.net
BSD 3-Clause "New" or "Revised" License
18 stars 17 forks source link

n(d).white.fresh theme preview is wrong or is being poorly generated #148

Open perrocochino666 opened 4 years ago

perrocochino666 commented 4 years ago

Describe the problem and steps to reproduce it:

Preview of https://addons.thunderbird.net/es/thunderbird/addon/nd-white-fresh/?src=cb-dl-created is wrong

What happened?

image

What did you expect to happen?

This is Theme in Thunderbird image

Anything else we should know?

(Please include a link to the page, screenshots and any relevant files.)

Sancus commented 4 years ago

Not a bug on the website, that's what the theme looks like. There may be a bug in your installation of Thunderbird, perhaps you have a conflicting add-on, theme, or some other setting. Or it's not enabled properly. I don't know. You can find support at https://support.mozilla.org/en-US/questions/new/thunderbird

This is what the theme looks like when it's installed and working correctly in Thunderbird 78.2.2:

image

perrocochino666 commented 4 years ago

The error occurs when I upload the XPI file and your system automatically generates a thumbnail, this thumbnail image this is worng, my theme n(d).white.fresh, as the name implies, it is cool white and does not include any dark or black sectors The error does not appear in the installation of the theme and the capture that you show me is correct

Sancus commented 4 years ago

Your first screenshot didn't show the icon so I thought that was what you were reporting. You're correct the preview is somewhat wrong,

I suspect this is due to the newer property names and we don't have the patch that fixes the preview generator for those yet. Will eventually fix.

perrocochino666 commented 4 years ago

Thank you.

Sancus commented 3 years ago

Likely patches here: https://github.com/mozilla/addons-server/commits/master/src/olympia/versions/tasks.py that will fix this that need backporting.