thunderbird / addons-server

🕶 addons.thunderbird.net Django app and API, forked from addons.mozilla.org 🎉
https://addons.thunderbird.net
BSD 3-Clause "New" or "Revised" License
18 stars 17 forks source link

Test fixes #215

Closed MelissaAutumn closed 7 months ago

MelissaAutumn commented 1 year ago

Resolves #207

This is a huge PR mostly due to the inclusion of the latest products json files (which the docker container generates on build iirc?) This update happened to fix some tests. 🤔

We should also merge the docker-fixes to master so we can change the target branch of this PR to master.

Unfortunately this was mostly an exercise of whack-a-mole. Not the cleanest, but I figured if we can at least get the API routes solidly tested, we can move ahead with any major upgrades.

So here's some notes:

We should definitely squish this PR, lmk if I should pre-squish these commits.

(It would also be nice to maybe get a CI going with this project.)

MelissaAutumn commented 1 year ago

I ran the squish merge on the new docker image (separate PR) and we may have some test regressions lol. But much better than before:

======== 143 failed, 5542 passed, 48 xfailed, 1 xpassed, 31 warnings, 2 error in 1569.96 seconds ========

This should be good after a master rebase.