search

thunderbird / addons-server

🕶 addons.thunderbird.net Django app and API, forked from addons.mozilla.org 🎉
https://addons.thunderbird.net
BSD 3-Clause "New" or "Revised" License
18 stars 17 forks source link

Add-on Review shows incorrect queue size #270

Closed jobisoft closed 7 months ago

jobisoft commented 7 months ago

When I log in as add-on reviewer, a wrong number of pending reviews is shown:

image

Even though the review queue is empty, it reports 64 add-ons stuck in the review queue.

Sancus commented 7 months ago

That's quite odd, not sure what it would be offhand. Mel can take a look at some point (not high priority).

MelissaAutumn commented 7 months ago

These mystery files seem to be the tb-langpack for 123. Their files are unapproved/awaiting approval. It seems like the code expects a web extension (which tb-langpacks are) without any of the criteria there to be automatically approved. (https://github.com/thunderbird/addons-server/blob/master/src/olympia/reviewers/views.py#L506)

Is the auto approval cron running correctly? @Sancus

Sancus commented 7 months ago

Indeed it was not, that should be corrected now. I don't see any of those add-ons in the queue anymore, reopen if this happens again.