thunderbird / addons-server

🕶 addons.thunderbird.net Django app and API, forked from addons.mozilla.org 🎉
https://addons.thunderbird.net
BSD 3-Clause "New" or "Revised" License
18 stars 17 forks source link

Add web extension permission description to the permissions tab. #272

Closed MelissaAutumn closed 4 months ago

MelissaAutumn commented 4 months ago

I still need to test this, but the intention is to display the normal web experiment permission description on ATN.

Based on tb.net country rankings I've grabbed some potentially popular localizations off of Pontoon. ATN used to import the actual descriptions, but that hasn't been updated since Thunderbird migrated to fluent strings. So had to do some manual work.

I also removed the second sentence since it was technically untrue, as we don't have modular permission granting. (Correct me if I'm wrong there.) Due to the fact this project isn't actively localized I can't really just edit the sentence to only say "Hey it can be dangerous!"

Sancus commented 4 months ago

Mail extensions using the built-in APIs only do have modular permission granting, it's only experiments that do not.

jobisoft commented 4 months ago

In Thunderbird, if an extension uses experiments, we do not show any permissions beside the "Has full access to your computer" permissions. Test add-on: https://addons.thunderbird.net/addon/smarttemplate4/

This probably causes a follow-up: If an extension is not requesting any permissions, but is an experiement, the permission popup is not shown on ATN. test add-on: https://addons.thunderbird.net/addon/quicktext/

MelissaAutumn commented 4 months ago

Mail extensions using the built-in APIs only do have modular permission granting, it's only experiments that do not.

Where is this located on the Thunderbird UI? I only get the "Add" or "Cancel" dialog window when adding an addon with web extension permissions. The text in the second paragraph seems to imply that the user can control permission granting which doesn't seem to be the case.

And thanks @jobisoft I'll adjust it hide any additional permissions if its an experiment.

jobisoft commented 4 months ago

Mail extensions using the built-in APIs only do have modular permission granting, it's only experiments that do not.

Where is this located on the Thunderbird UI? I only get the "Add" or "Cancel" dialog window when adding an addon with web extension permissions. The text in the second paragraph seems to imply that the user can control permission granting which doesn't seem to be the case.

And thanks @jobisoft I'll adjust it hide any additional permissions if its an experiment.

The install dialog asks for all fixed permissions during install. There is however the option to later inspect which permission an add-on has requested. Go to the add-on manager and click on an add-on and in the details view there is a permission tab. If the add-on has optional permissions, they can be toggled there.

Optional permissions are supported, but are not widely used. I think I have to do some work on that during the next cycle.

MelissaAutumn commented 4 months ago

Thanks for the clarification. I'll re-add that sentence!

MelissaAutumn commented 4 months ago

And adjusted!

MelissaAutumn commented 4 months ago

I'm going to merge this for some testing on stage, if there's additional feedback please post it here!