Closed MelissaAutumn closed 6 months ago
On production viewing the activity logs produces a 500 error during serialization of the arguments.
Occurs: https://github.com/thunderbird/addons-server/blob/master/src/olympia/activity/models.py#L388
Due to: https://github.com/thunderbird/addons-server/blob/master/src/olympia/activity/models.py#L309
Suggested fix: Add a none check to to_string before the argument loop and return "" or something to that effect.
On futher investigation it seems like we're trying to json.loads an empty string. So we should also add an empty string check for arguments.
json.loads
On production viewing the activity logs produces a 500 error during serialization of the arguments.
Occurs: https://github.com/thunderbird/addons-server/blob/master/src/olympia/activity/models.py#L388
Due to: https://github.com/thunderbird/addons-server/blob/master/src/olympia/activity/models.py#L309
Suggested fix: Add a none check to to_string before the argument loop and return "" or something to that effect.