search

thunderbird / addons-server

🕶 addons.thunderbird.net Django app and API, forked from addons.mozilla.org 🎉
https://addons.thunderbird.net
BSD 3-Clause "New" or "Revised" License
18 stars 17 forks source link

Remove personas from profile #296

Closed MelissaAutumn closed 5 months ago

MelissaAutumn commented 5 months ago

Fixes #249

Seems to be a side-effect of https://github.com/thunderbird/addons-server/issues/284. Some personas still have their addons but not their persona record. I'm not sure why, and it's possible these are the personas that were causing the celery tasks to fail. Follow up ticket: https://github.com/thunderbird/addons-server/issues/295

Tested on stage, and it works. Although there's some small tweaks I could do to make it prettier. (Like not counting personas towards # of themes.)

I also added a check in the persona preview template fragment.

github-actions[bot] commented 5 months ago

Test Results

5 491 tests  ±0   5 377 :white_check_mark:  - 25   27m 18s :stopwatch: - 1m 39s     1 suites ±0      25 :zzz: ± 0      1 files   ±0      89 :x: +25 

For more details on these failures, see this check.

Results for commit 031df1f1. ± Comparison against base commit 9f2a58ff.