thunderbird / appointment

Invite others to grab times on your calendar. Choose a date. Make appointments as easy as it gets.
https://appointment.day
Mozilla Public License 2.0
203 stars 8 forks source link

regression: Distinguish Tentative/Optional Meetings from Accepted #324

Closed solangevalverde closed 4 months ago

solangevalverde commented 6 months ago

Describe the bug Accepted and not accepted/tentative/optional meetings are displayed the same way

To Reproduce Steps to reproduce the behavior:

  1. connect a calendar
  2. go to the calendar page on a day/week/month where a non confirmed meeting is located

Expected behavior see a different kind of design for those unconfirmed meetings

Actual behavior unable to distinguish Tentative/Optional Meetings from Accepted

Screenshots If applicable, add screenshots to help explain your problem.

System (please complete the following information):

Additional context the enhancement from this closed bug has regressed.

Current design to follow: image

MelissaAutumn commented 6 months ago

Thanks! Context: This probably regressed during the switching of calendar components.

MelissaAutumn commented 5 months ago

Swapped this to within-alpha as it should be doable (its a regression so we have the backing data). But lmk if theres any blockers.

devmount commented 4 months ago

I did some attempts to solve this but it turned out, that our CalendarEvent.vue component became a bit too complex, especially this part:

image

I will take the opportunity and split that into several elements / components to make style changes simple / possible again 😅

MelissaAutumn commented 4 months ago

Yeah, we just have too many states on that one component. Feel free to split it one component per state, or however else you'd like. Thanks!