search

thunderbird / appointment

Invite others to grab times on your calendar. Choose a date. Make appointments as easy as it gets.
https://appointment.day
Mozilla Public License 2.0
204 stars 8 forks source link

"No Confirmation Needed" or "Confirmation Needed" #460

Closed ryanleesipes closed 1 week ago

ryanleesipes commented 4 months ago

I like to confirm meeting times, but some people may not need to. We should expose an option in the short-term (and in the long-term expose this in onboarding) to be able to turn off confirmation (or we could choose to make that the default and have a "Confirmation Needed" option that you turn on). So that folks can allow people to grab time on their calendars instantly with no confirmation required.

devmount commented 3 months ago

I'll take care of that. Where should that "Confirmation Needed" option live? On the schedule page? Like e.g. here?

image

cc @MelissaAutumn @solangevalverde

malini commented 3 months ago

I'll loop in design now, but let's just ship with something that we're okay with until then.

malini commented 3 months ago

@devmount I'm okay with that location for now, let's do it!

devmount commented 3 months ago

Alright, will do! Thank you!

laurelterlesky commented 2 months ago

@malini Can we reopen this?

See the design solve here: https://www.figma.com/design/rDjrWQsgejQUyACjjXRwVa/TBA_2024_Q3_BookingConfirmationToggle?node-id=1-6&t=MnNACwn5bFQfifjV-1

cc: @solangevalverde

MelissaAutumn commented 1 month ago

I don't have access, but I've swapped this over to mvp as the feature is in, just not as designed..which I can't see 😅

ryanleesipes commented 1 month ago

Let's post images in when possible. Not just for Mel, but also so that contributors can follow along.

devmount commented 1 month ago

Thanks @ryanleesipes, totally agree! I'll take a look at this (I have access to that Figma).

laurelterlesky commented 1 month ago

Screenshot 2024-09-05 at 14 47 34

laurelterlesky commented 1 month ago

@devmount Do you need a dark mode mockup?

devmount commented 1 month ago

@laurelterlesky Yes, that would be great 🙏🏻

laurelterlesky commented 4 weeks ago

Screenshot 2024-09-07 at 15 50 34

MelissaAutumn commented 3 weeks ago

@devmount implemented the new section and updates. I went in and tweaked the style to fit the font-size, and edgecases I ran into. Additionally I've added a max length of 16 characters, and the username will overflow into /melissa@th.../ <editable section> if the username is too long.

image
MelissaAutumn commented 3 weeks ago

Oops just noticed there's some additional design tweaks of replacing the buttons with tbpro components. Can you convert the rest of the form to tbpro components @devmount ?

We can also cut a different ticket for that.

devmount commented 3 weeks ago

@MelissaAutumn Of course, I'll replace the buttons and input elements. We can add new tbpro elements (e.g. for those accordion cards) once we got that services-ui repo up an running!

devmount commented 3 weeks ago

Keeping this open since we still need to style: