search

thunderbird / appointment

Invite others to grab times on your calendar. Choose a date. Make appointments as easy as it gets.
https://appointment.day
Mozilla Public License 2.0
212 stars 8 forks source link

X-Forwarded-For Headers are not being trickled down to the containers #581

Closed malini closed 1 month ago

malini commented 2 months ago

Describe the bug From a metrics discussion in team chat, we discovered that the backend containers aren't getting the X-Forwarded-For http header in received requests (here's a sample request, if you scroll to the bottom, you'll see the HTTP headers). Joe's confirmed that CloudFlare is sending it, but we have to investigate the CloudFront->ALB->ECS http request path to see where the header is being dropped.

This header (or at least a solution around this) is needed for metrics gathering and rate limiting.

malini commented 2 months ago

tracking it for beta v2, since we should have rate limiting in place prior to public beta IMO

MelissaAutumn commented 2 months ago

Blocks #566 Blocks #573

MelissaAutumn commented 1 month ago

Turns out this is forwarding, sentry is hiding it. Confirmed on stage.