thunderbird / appointment

Invite others to grab times on your calendar. Choose a date. Make appointments as easy as it gets.
https://appointment.day
Mozilla Public License 2.0
219 stars 8 forks source link

A new user should be able to set a Google/Microsoft/Yahoo/...) account #713

Open NicolasWeb opened 3 weeks ago

NicolasWeb commented 3 weeks ago

Describe the bug As a new user, the setup wizard prompted me to connect my Google account & allow TB Appointment, even if I don't use it for my calendars (NextCloud). I didn't had a visible alternative at the same step to use a CalDav config. I wasn't able to skip the step and go forward in the wizard.

To Reproduce Steps to reproduce the behavior:

  1. Go to the step Connect your account in the wizard
  2. Do not select any choice proposed (Google/Microsoft/Yahoo)
  3. Try to find a way to set a CalDAV account while not setting a GAFAM account
  4. Try to go to next step (maybe it's after in the wizard)

Expected behavior

Actual behavior

MelissaAutumn commented 1 week ago

Hello! We've recently pushed up CalDAV auto-discovery of a principal server during the FTUE / Setup wizard. Can you confirm this works as requested on your end?

Cheers, Mel

NicolasWeb commented 4 days ago

Hello ! That's definitely better : in the FTUE, the user can set a CalDav without connecting a GAFAM account. A big thank you for that !!

In my professional life, I'm a QA, so... ;)

While testing, the limitations I've experienced are:

(tell me for which you want me to fill bugs, please ?)

  1. Create your profile step: a. I miss explanation labels at the bottom of the text inputs (as at the CalDAV/Select your calendar Provider step). i. Full Name is the Display name ii. Username : Which one ? is that for login to TBA ? Then Username is clearly not clear, as I get redirected to Mozilla account then. So that step is waiting for a Mozilla account login. The same goes with Settings/account/Username

  2. Select calendar step: a. That dialog is definitely too verbose b. I would prefer to get tiled options (like the dialog for video link) instead of buttons to switch provider : I dislike that GAFAM is the default

  3. Select your calendar Provider step: a. Location i. Location input need to be wider to input all what is needed. I don't understand the Design choice Large dialog with so small text inputs ii. Not clear if I should paste the CalDAV principal https:///remote.php/dav, macOS https:///remote.php/dav/principals/users// or the one that is in the properties in TB Desktop https:///remote.php/dav/calendars/CalDAVusername>/ b. Password : i. It does not work with my CalDAV account psw, and works ONLY with a Application Password ii. I wait here to be more assisted, like it is with TB Desktop : connect with my CalDAV account psw and be prompted to allow the connection, creating and using an app psw. c. Error : the error message needs to be more precise to help the user solve it: Username/Location/Password issue ? (Actually just 'Something went wrong')

  4. Connect calendars step a. The Back button should go back to the 'Select your calendar Provider step' with all inputs. But it actually go to the step before (Select calendar step), and when you choose 'Switch to CalDAV' all the user inputs are lost in 'Select your calendar Provider step:' b. As a user, I would like to get the calendars colors at this step

  5. Connect your video meeting link a. As I setup a CalDAV, I would appreciate to not be recommended Zoom. In that case, that does not seem consistent for the user

Other issues found:

  1. Settings/calendar/Edit calendar & settings/connectedAccounts : the background color is discontinued if you scroll down. And so, the Disconnect button is not really visible

  2. Linked to FTUE point 1., TBA profile/account is not clear. If the user go to Settings/account/, the user have a profile But if she click on the top right corner (header) profile_button/User_profile, it goes to Mozilla Account

  3. If the user creates a Mozilla account from the TBA FTUE, then a. The default TBA header profile_button text is 'T' and not her initials b. The display name set in TBA is not taken in the Mozilla Account

  4. After accounts creation, if the user click on the header profile_button/User_profile, it goes to Mozilla Account and has no way to go back to TBA (except browser backward button)

NicolasWeb commented 3 days ago

(Sorry to comment here, as it it a follow-up about 'Other issues found'. But before creating new Github issues, it seems consistent here)

About the TBA account / Mozilla Account : it seems the parent profile is the Mozilla account one. And it is mandatory for TBA. As a user, I would like to know that the TBA account is dependant to my Mozilla account, so I can have a consistent behavior with my data.

Proposition 1 :

I would find it more consistent to have the FTUE flow as :

  1. Connect/Create a Mozilla account
  2. Prefill data : Mozilla account data -> TBA profile
  3. Customize TBA profile data in FTUE (if there is / only for data with any value for the user : Maybe only the display name ?)

This is the flow users are used to from other services providers (like with Microsoft account : Exchange, Teams, ...)

Proposition 2 :

An alternative, would be to have an 'I already have a Mozilla account' (like the 'Switch to CalDAV') button in the 'Create your profile' step. Then, if the user already have a Moz account (TB Sync, Firefox, Mozilla VPN, ...) for her organisation's account, she avoid creating a new one.