thunderbird / appointment

Invite others to grab times on your calendar. Choose a date. Make appointments as easy as it gets.
https://appointment.day
Mozilla Public License 2.0
228 stars 8 forks source link

On first load of the General Availability page, the prev/next month buttons do not work properly #730

Open radishmouse opened 1 month ago

radishmouse commented 1 month ago

General Availability prev/next month arrow buttons do not work on first load

Clicking the arrow to go to the next month skips a month. Clicking the arrow to to go the previous month does nothing.

This only happens on first load of the General Availability page.

Note: Clicking the arrows to go from month to month act normally after the initial click.

To Reproduce

  1. Visit a user's general availability calendar
  2. Click the arrow to go to the next month or the previous month

Expected behavior If it's currently October:

Actual behavior If it's currently October:

Screenshots

Reloading the page, then clicking the arrow to go to next month skips a month: Screencast_20241030_170002.webm

Reloading the page, then clicking the arrow to go to the previous month does nothing (until it is clicked a second time): Screencast_20241030_171220.webm

System (please complete the following information):

devmount commented 1 month ago

Good catch, I'll take a look at this.

devmount commented 1 month ago

@MelissaAutumn I analyzed this and found that this is very likely a Qalendar bug happening only at the end of a month apparently. It happens in both our Qalendar views (dashboard and booking view). If the booking view schedule starts at Nov 1 all is working fine. If it starts at Oct 31, the bug strikes.

How do we want to proceed on this? Should we file a bug report? Or should we find a work around? Or both? I remember there was a discussion about ditching Qalendar / Calendar views, so maybe it's not worth the effort.

devmount commented 1 month ago

I just saw that Qalendar is no longer maintained, so we'd have to find a workaround.

MelissaAutumn commented 1 month ago

That's fun. I think there's some plans to redo the booking page. I've forked it a while ago with intention that we'd maintain / theme it as needed / fix any bugs we find though: https://github.com/thunderbird/qalendar

So if there's a low-effort fix we can apply that would solve this that would work, but if it's more than an hour, we should verify if we're planning on removing qalendar soon.

devmount commented 1 month ago

Alright, I'll see if I can fix it. We should still verify the Qalendar removal imho.