search

thunderbird / developer-docs

Developer documentation for Thunderbird contributors.
https://developer.thunderbird.net
82 stars 77 forks source link

Do we still QI windows to nsIMsgWindow? #86

Closed eyalroz closed 4 years ago

eyalroz commented 4 years ago

On this page, it says:

With TB70, window objects don't need to be and cannot be QI'ed to nsIDOMChromeWindow, nsIDOMWindow and nsIInterfaceRequestor. You can just remove its usage, this is backwards compatible to TB 68. See the fix applied to enigmail.

but what about other interfaces? e.g. nsIMsgWindow? Do we still need to QI for that? This should be clarified.

jobisoft commented 4 years ago

I disagree. It is a list of affected interfaces. We do not have to list all the interfaces which do not require this.

jobisoft commented 4 years ago

But it could of course be, that we missed an interface. If you find one, than we will of course add it to the list.

eyalroz commented 4 years ago

We do not have to list all the interfaces which do not require this.

Indeed, but it's not clear that you haven't. The distinction between "no need to QI at all" and "some of the interfaces don't need QIing anymore, the rest do" is not clear enough.

jobisoft commented 4 years ago

In ESR60 and ESR68 I did not find any usage of QI(nsIMsgWindow):

https://searchfox.org/comm-esr68/search?q=QueryInterface\(.*nsIMsgWindow&path=&case=false&regexp=true

but a lot of QI(nsIDOMWindow) (so the query works):

https://searchfox.org/comm-esr68/search?q=QueryInterface\(.*nsIDOMWindow&path=&case=false&regexp=true

I tend to close this as irrelevant. If you can, please provide a code fragment where you had to QI to nsIMsgWindow so we can check if it is still possible/neeed.

eyalroz commented 4 years ago

I just suggested a phrasing tweak. But - ok.