v14.0.1 Help cannot be opened in a window from the icon in the options

[kiki-ja]

ImportExportTools NG 14.0.1 Thunderbird 115.4.2 64bit Windows 10 Pro 22H2 64bit

Reproduction procedure: １． Check on the option 'Open help in a window instead of a tab'. ２． Click on the icon in the options. ３． Help opens in a tab.

In 14.0.1-b7 it opened in a window. I would like it to open in a window as well.

@kiki-ja

[cleidigh]

@kiki-ja I am so frustrated I broke this and didn't catch it. The whole multiple main windows issue broke almost all commands and my fix at the last moment did not contemplate all scenarios. I understand what happened now. I think I know how to handle it. The white issue revolves around each window having a command handler and having duplicate command responses. I have to now have the command handlers only react to the correct request.

I am sorry I messed this up. Fix one thing and break something else %-( @cleidigh

[kiki-ja]

@cleidigh

I am praying it will be fixed in the next release. I also hoping my modified ja importexport-help.html will also be replaced.

Thanks.

@kiki-ja

[cleidigh]

@kiki-ja I don't understand how the help was not right. I already started v14.0.2 and have a test solution for the help and multiple windows. My thoughts are to just get this out as soon as I have the fix and not wait for anything else. Sorry this got messed up @cleidigh

[kiki-ja]

@cleidigh

I don't understand how the help was not right.

It was not wrong, but rather I reviewed the Japanese wording of the 14.0.1 Release Notes in the Help. Only two areas have been revised to make them clearer, more communicative, and easier to understand.

However, if it is determined that the current situation is acceptable, there is no need to replace it.

@kiki-ja

[cleidigh]

Hi Kiki Of course we can update for v14.0.2

You can send and I will merge

I have already gotten a version working with both multiple windows and help in Window I may send you b1 tomorrow. The biggest thing will be testing as this affects all commands Christopher

On Wed, Nov 15, 2023 at 9:02 PM kiki @.***> wrote:

@cleidigh

I don't understand how the help was not right.

It was not wrong, but rather I reviewed the Japanese wording of the 14.0.1 Release Notes in the Help. Only two areas have been revised to make them clearer, more communicative, and easier to understand.

However, if it is determined that the current situation is acceptable, there is no need to replace it.

@kiki-ja

— Reply to this email directly, view it on GitHub https://github.com/thunderbird/import-export-tools-ng/issues/498#issuecomment-1813654275, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAZ7645CSQYC4ME3JVYHGTYEVX2BAVCNFSM6AAAAAA7JKWG4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJTGY2TIMRXGU . You are receiving this because you were mentioned.Message ID: @.***>

[kiki-ja]

@cleidigh

You can send and I will merge.

I have already attached it to https://github.com/thunderbird/import-export-tools-ng/issues/461#issuecomment-1806617406.

I can't do all the testing, but I will test and confirm this issue.

@kiki-ja

[cleidigh]

@kiki-ja This should fix the winhelp issue. I had a crazy day so I still have to fix ja help. https://github.com/thunderbird/import-export-tools-ng/blob/v14.0.2/xpi/beta/import-export-tools-ng-14.0.2-b1-tb.xpi @cleidigh

[kiki-ja]

@cleidigh

This should fix the winhelp issue.

I have confirmed it has been fixed. Thank you for your time. Thanks.

@kiki-ja

[DenB10]

@cleidigh

Versions 14.0.2 beta fix the problem of opening help in a window, but seem to introduce another bug: the "Backup" command in the tools menu no longer works (the backup window doesn't open). Can you reproduce this?

Edit: I solved the problem by replacing line 881 of the wextMenus.js file with this one: messenger.NotifyTools.notifyExperiment({ command: "WXMCMD_Backup", params: params }); but I don't know if my modification is correct?

@DenB10

[cleidigh]

Denis Yes you are spot on. Good sleuthing! I don't think you ever told me your background, but obviously software experience is there %-) The params became a requirement after adding the target window to not have the cmdDispathers fire for non focused windows.

So fyi I am going to start a long overdue feature addition, structured and with attachments PDF output. This is pretty much the top enhancement request. I have to do it bottom up to be aligned with the web extension approach. Gotta gear up, it will be a big effort for me. Cheers Christopher

On Sat, Nov 25, 2023 at 8:18 AM DenB10 @.***> wrote:

@cleidigh https://github.com/cleidigh

Versions 14.0.2 beta fix the problem of opening help in a window, but seem to introduce another bug: the "Backup" command in the tools menu no longer works (the backup window doesn't open). Can you reproduce this?

@DenB10 https://github.com/DenB10

— Reply to this email directly, view it on GitHub https://github.com/thunderbird/import-export-tools-ng/issues/498#issuecomment-1826305920, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAZ7667YTB6ZNYBE57DCBTYGHV3PAVCNFSM6AAAAAA7JKWG4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGMYDKOJSGA . You are receiving this because you were mentioned.Message ID: @.***>

[DenB10]

Hi Christopher,

Sorry, you're wrong, I have absolutely no software experience, just curiosity, observation, tinkering and... luck. I do admire software developers, but I'll never have their skills, it's too late for me to learn.

I wish you good courage with your project to improve IETNG. I hope you are well, and that your health is relatively good at the moment.

Denis

[cleidigh]

Well you fooled me, very good observation indeed! Christopher

On Sun, Nov 26, 2023 at 1:18 PM DenB10 @.***> wrote:

Hi Christopher,

Sorry, you're wrong, I have absolutely no software experience, just curiosity, observation, tinkering and... luck. I do admire software developers, but I'll never have their skills, it's too late for me to learn.

I wish you good courage with your project to improve IETNG. I hope you are well, and that your health is relatively good at the moment.

Denis

— Reply to this email directly, view it on GitHub https://github.com/thunderbird/import-export-tools-ng/issues/498#issuecomment-1826859545, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAZ766GYC2EGPDZMJJTM53YGOBWDAVCNFSM6AAAAAA7JKWG4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWHA2TSNJUGU . You are receiving this because you were mentioned.Message ID: @.***>