thunderbird / thunderbird-android

K-9 Mail – Open Source Email App for Android
https://k9mail.app/
Apache License 2.0
9.78k stars 2.45k forks source link

Reproducible RecipientSelectView bug introduces extraneous chars into text #3257

Closed markcapella closed 6 years ago

markcapella commented 6 years ago

See: https://www.dropbox.com/s/4mtyhzxdjzsb6gi/fix%20IMM%20issue.mp4?dl=0

During entry of To/Cc/Bcc fields, after completion of a recipient by tapping a suggested Icon from the contacts list, subsequent typing will re-add text from the previous typing that led to the selection of the Icon/Token in the dropdown.

See the video I've attached. The K9 with the RED ICON exhibits the issue. The K9 with the PURPLE ICON, exhibits the fix.

This probably needs to get posted to the com.splitwise:tokenautocomplete:2.0.7 GITHUB also, but I started out trying to fix you, so here's an override of one of their methods.

You can recreate the issue, by typing THREE CHARS of a contact in your list with a valid email entry, then selecting the Icon/Token by tapping. The next char typed will re-generate the three previous chars in the internal buffer.

Three chars is important as during the token substitution, it leaves the View selection length as is, tricking the IMM into avoiding an internal reset.

cketti commented 6 years ago

I can't reproduce the issue you're seeing. What Android version and keyboard are you using?

Valodim commented 6 years ago

I also experience it, and it's extremely annoying. Thanks for looking into this

cketti commented 6 years ago

Fixed by #3258