search

thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
10.98k stars 2.51k forks source link

"Show pictures" button displayed even if pictures already downloaded #4900

Open starshipcoder opened 4 years ago

starshipcoder commented 4 years ago

Expected behavior

"Show pictures" button should be hide if all pictures are already present

Actual behavior

"Show pictures" button is always displayed when selecting a mail

Steps to reproduce

  1. Select a message
  2. Click on "show pictures" -> pictures are downloaded
  3. Select another message
  4. Reselect the first message Bug: the button is showed whereas the pictures are present

Environment

K-9 Mail version: 5.717

Android version: 9

Account type (IMAP, POP3, WebDAV/Exchange):

cketti commented 4 years ago

Unless the "Show pictures" button was pressed we disable all network requests. If remote images are displayed anyway they are read from WebView's cache. I don't know if we can reliably detect this case to hide the button.