search

thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11.04k stars 2.51k forks source link

v5.802 doesn't retract android notification on delete of unread message #5545

Closed mmhere closed 3 years ago

mmhere commented 3 years ago

Describe the bug Separate IMAP client deletes unread message, v5.802 does not retract New Message notification previously posted when IMAP PUSH saw new msg arrive

To Reproduce

  1. send message to an account watched via IMAP PUSH by K-9 v5.802
  2. K-9 posts a notification immediately (cool)
  3. via another IMAP client (desktop, even K-9 v5.600 on another android), delete the message before marking it read
  4. Android notification previously posted by K-9 v5.802 is not retracted and stays visible (note that v5.600 properly retracts in such a case)

Expected behavior A message never marked read but deleted by another client should retract K-9's previously posted new-message notification.

Environment:

Additional context Note as mentioned above, v5.600 (K-9) does retract notifications in such cases

A work-around that the end-user may practice is as follows:

Whichever separate non-K9(v5.802) IMAP client is being used (desktop client of some form on another machine, K-9 v5.600 itself on another Android device), if you FIRST mark the newest message read, THEN delete that newest message, K-9 v5.802 DOES properly retract the previously posted new-msg android-notification.

So I'm wondering if K-9 v5.802 could be changed to treat a message deletion (for a message just received and for which the android system notification was posted, and which is still an unread message) as experiencing both an "is read" and "is deleted" state change?

I realize, having briefly scanned the issues list here that there are many challenges surrounding android notifications, and that this may not be an easy thing to track down and solve. I hope I've provided enough info.

In summary:

message arrives, remains new/unread, is deleted from another IMAP client, K-9 v5.802 leaves the android notif up (while 5.600 removes the notif under the same conditions).

conversely:

message arrives, remains new/unrerad, is first marked read from another IMAP client, then deleted from another IMAP client, K-9 v5.802 tears down the android notif previously posted for the new message.

mmhere commented 3 years ago

That code looks cool. I'll check it out in whichever next release has it. Is this item interesting enough to be mentioned in the release notes' bullet list? If so I'll know when to look for it.

cketti commented 3 years ago

The fix should be released with K-9 Mail 5.803.

mmhere commented 3 years ago

The fix should be released with K-9 Mail 5.803.

Most excellent. Thank you for your hard work on this project and the recent steady stream of releases. With this bug fix I think I shall be able to permanently move from 5.600 to the 5.8xx series.

Coolness has been attained.

mmhere commented 3 years ago

Woo Hay! I can confirm that 5.803 works as expected

Same systems and setup as before.

A new message arrives, notif is posted on Android. Delete the message in some other IMAP client without first marking it read, notif disappears on the Android running 5.803.

Thanks very much!