search

thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/
Apache License 2.0
10.06k stars 2.47k forks source link

new dark theme is brownish and not black (harder to read) #7864

Open AnthillSudoku opened 4 months ago

AnthillSudoku commented 4 months ago

Checklist

App version

6.901

Where did you get the app from?

Other

Android version

12

Device model

samsung a52q

Steps to reproduce

Old dark theme wasn't pure black and did not support amoled feature, but at least it were easier to read. The new even has even less contrast between the background and the text, making it harder to read.

new dark theme

Imagepipe_1

I put the screenshot of the left pane, but the same goes for the messages list and message UI

old dark theme

Imagepipe_0

Expected behavior

dark theme is close to black

Actual behavior

Dark theme is brownish

Logs

No response

AnthillSudoku commented 4 months ago

While here https://github.com/thunderbird/thunderbird-android/issues/7856 the issue already came out in the comments, the submitter asked for more colors and did not focus on black theme

wmontwe commented 4 months ago

There are some known contrast issues with the new dark color scheme and we're working on a fix.

uniquePWD commented 3 months ago

It should probably be noted that black doesn't fair well with user experience research

cketti commented 3 months ago

I think it would be helpful to anyone reading this if you provided links to relevant user experience research.

uniquePWD commented 3 months ago

I think it would be helpful to anyone reading this if you provided links to relevant user experience research.

https://tatham.blog/2008/10/13/why-light-text-on-dark-background-is-a-bad-idea/

https://uxmovement.com/content/why-you-should-never-use-pure-black-for-text-or-backgrounds/

MillionsToOne commented 3 months ago

That is just pure propaganda from light mode users. Even common sense should tell you to not be on a computer all the time.

baccyflap commented 3 months ago

The idea that white-on-not-quite-black (or gray-on-white) is somehow more legible than black-and-white is a pervasive one. This NN article is the closest thing I could find to a reliable source, though it doesn't explicitly discuss dark mode - it just recommends high contrast overall, much like W3C.

There are some inconclusive small-scale studies which seem to be mostly from the 90s and early 2000s, when displays looked rather different. All the rest seems to be down to preference and UX fairystories - talk of 'cool blacks' and 'warm grays', that sort of thing.

thatguy764 commented 2 months ago

I think it would be helpful to anyone reading this if you provided links to relevant user experience research.

https://tatham.blog/2008/10/13/why-light-text-on-dark-background-is-a-bad-idea/

https://uxmovement.com/content/why-you-should-never-use-pure-black-for-text-or-backgrounds/

Pissing off your user base by suddenly changing the look and feel they've used for years also creates a bad user experience. Not everyone will necessarily want to use the "super ergonomic better for your eyes solarized IDE" style option and that's okay, even if using something like the current existing dark mode is slightly more eye straining for them. That is of course even assuming this research is accurate, if I'm recalling correctly a lot of human factors research on eye strain was done during the CRT era, and I'm sure some was done during the LCD era, and now we're split between those and OLEDs so it's not even universal at the moment. It's also worth keeping in mind that most UX research is best practices or guidelines at best, it's rarely by any means definitive so you should always take it with a grain of salt and not try to wield it like a big stick.

Given that the point of free software is user choice, leaving the traditional dark mode as an option along with one or more ergonomic/accessibility style themes seems like a pretty reasonable middle ground.

MillionsToOne commented 2 months ago

I think it would be helpful to anyone reading this if you provided links to relevant user experience research.

https://tatham.blog/2008/10/13/why-light-text-on-dark-background-is-a-bad-idea/

https://uxmovement.com/content/why-you-should-never-use-pure-black-for-text-or-backgrounds/

Pissing off your user base by suddenly changing the look and feel they've used for years also creates a bad user experience. Not everyone will necessarily want to use the "super ergonomic better for your eyes solarized IDE" style option and that's okay, even if using something like the current existing dark mode is slightly more eye straining for them. That is of course even assuming this research is accurate, if I'm recalling correctly a lot of human factors research on eye strain was done during the CRT era, and I'm sure some was done during the LCD era, and now we're split between those and OLEDs so it's not even universal at the moment. It's also worth keeping in mind that most UX research is best practices or guidelines at best, it's rarely by any means definitive so you should always take it with a grain of salt and not try to wield it like a big stick.

Given that the point of free software is user choice, leaving the traditional dark mode as an option along with one or more ergonomic/accessibility style themes seems like a pretty reasonable middle ground.

All I can say is "Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."

baccyflap commented 2 months ago

I'd be interested in an update on this bug, if it's available; the inexplicable brown colouration is driving me a little nuts.

MillionsToOne commented 2 months ago

I'd be interested in an update on this bug, if it's available; the inexplicable brown colouration is driving me a little nuts.

It isn't a bug. MD3 and MY is a work-in-progress, so MY colors haven't been merged yet. Otherwise it would use wallpaper colors. You can stay on latest stable release if colors bother you.

baccyflap commented 2 months ago

Yes sorry, an issue rather than a bug. So once that's finished, it'll use wallpaper colours? That'd solve the issue for everyone, I imagine.

MillionsToOne commented 2 months ago

Yes sorry, an issue rather than a bug. So once that's finished, it'll use wallpaper colours? That'd solve the issue for everyone, I imagine.

https://github.com/orgs/thunderbird/projects/4/views/7

In the Material 3 section.

MillionsToOne commented 2 months ago

Yes sorry, an issue rather than a bug. So once that's finished, it'll use wallpaper colours? That'd solve the issue for everyone, I imagine.

https://github.com/thunderbird/thunderbird-android/issues/6617#issuecomment-2149405793