search

thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
10.98k stars 2.51k forks source link

html signature support #794

Open GTP95 opened 9 years ago

GTP95 commented 9 years ago

As others have pointed out when this project was hosted on Google Code, would be really nice if you add html support in signatures too.

Zeitwaechter commented 9 years ago

bump

It doesn't look that good if I'm writing business e-mails without HTML signatures.

You know? Your Application is so superb! But it's clearly lacking this one feature.. :(

jurekam commented 8 years ago

bump

Any progress on this? This is a "given" option that is available in all other email clients, no matter what the platform. Please provide an update! Thank you.

GTP95 commented 8 years ago

Jurekam, do you know a free Android email client that supports html signature? If yes can you please tell me what it is?

cketti commented 8 years ago

This is a technical issue tracker, not a discussion forum. If you don't have technical details to add please use the mailing list.

In volunteer-run open source projects the answer to the question "when will it be ready?" is always "when it's done". I will delete further inquiries of this kind as they only add noise and no value.

R2116 commented 8 years ago

Isn't this rather a bug? You aldready distinguish between HTML/ no HTML within the code but it doesn't work https://github.com/k9mail/k-9/blob/master/k9mail/src/main/java/com/fsck/k9/message/TextBodyBuilder.java#L189

philipwhiuk commented 8 years ago

No its not. A bug is something that doesn't work. Not something that is missing. We don't supporting writing HTML formatted emails and signatures. That's not a bug.

That code does work. It converts plaintext into HTML formatted plain text. i.e. it replaces new lines with <br>'s

That doesn't mean you can use HTML formatting to write formatted text (i.e., bold, underline, links) which is what this bug is about.

This bug is either:

The second would be a bit ugly. The first is a lot of work.

In any case, bug vs enhancement is bikeshedding. It won't affect the speed at which it gets implemented.

nose-gnome commented 8 months ago

Is there a reason this hasn't happened yet? Is there something making this difficult to implement, if not, then I might be able to try and open a pull request to fix this, as this has been extremely annoying for me. Unless it's a lot of work to implement.

nikkyandrei commented 4 months ago

i agree with @nose-gnome in this moment i consider the biggest thing that is missing , i agree to write my entire HTML and use to external source for images in signatures . is frustrating that the body support HTML but signature not

Thank you and keep up the good work

derWalter commented 1 month ago

I am really here in 2024 to find out this is not a thing yet.

kewisch commented 1 month ago

Welcome to 2024 ;-) We'd love to have this as well, but there is only so much we can do at once. If someone wants to dive into contributing we're happy to help.

In the meanwhile, I think the best way to indicate your support is upvoting https://connect.mozilla.org/t5/ideas/allow-html-signatures-in-k-9-mail/idi-p/28983 . We use connect as one of many source for our roadmap.

BRKsays commented 1 month ago

Would it be possible to consider an incremental approach for implementing HTML signature support? Perhaps starting with image support first, so users can include logos or banners in their signatures. This would be a great intermediate step, especially for professionals who use branding in their communication.

Further down the line, a rich text editor for formatting (like bold, italics, and different fonts) could be gradually introduced. I think this step-by-step process might make development and testing easier, while providing immediate value to users.

Just a suggestion. I realise this is a volunteer work. Since this is a much requested feature maybe this can be tackled in a different way without increasing workload too much.

Retroguru commented 1 month ago

Please add this feature. I was about to switch from Spark to Thunderbird. Now I am hesitating to finish the setup and will keep my old email client.

lolcabanon commented 2 weeks ago
  • the implementation of an editor to write a signature (selecting text and bolding it, inserting links)
  • or an option to write HTML tags directly in the signature code.

The second would be a bit ugly. The first is a lot of work.

Hey, in the desktop version, you just check a box ([ ] Use HTML) and drop your HTML code in the box and It Works! I know the app should validate the code and protect against injection (which is the hard part I guess?) but I don't get what's "ugly" about that?

This is currently the only thing that prevent me from switching from Spark to Thunderbird Mobile for my work emails.

PhilippSchlesinger commented 1 week ago

In Thunderbird desktop version, you can attach a signature from (whether paintext or html, even an image is possible). This SUMO article even describes how to create a html signature with the Thunderbird composer.

In the first step it could be possible to just source the very same signature from a file on Thunderbird for Android as well. This feature is requested as an enhancement in https://github.com/thunderbird/thunderbird-android/issues/6138.