thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11k stars 2.51k forks source link

[EPIC] Material 3 drawer #8100

Open wmontwe opened 2 months ago

wmontwe commented 2 months ago

The navigation drawer should look and feel consistent with the rest of the K-9 Mail and Thunderbird for Android Material 3 theme. As the existing drawer is based on MaterialDrawer it has limited Material 3 support and doesn't allow us to easily adapt to the new design. Therefore we will rewrite the navigation drawer from scratch using Jetpack Compose.

Tasks:

To improve on:

Related bugs:

wmontwe commented 2 months ago

The existing drawer has a complex setup to communicate account and folder changes between itself, the MessageList, MessageFragment and different entry points (widgets, notifications). To simplify the communication flow we decided to introduce a separate view model to keep track of the currently active account and when needed selected folder. It should be bound to the lifecycle of the MessageList activity and exposed to the navigation drawer as single source of truth -> #8142

This caused a couple of lifecycle issues and the MessageList remains responsible for the account and folder states.

kewisch commented 12 hours ago

@marcRDZ You were asking if you could support on any other issues related to the drawer. @wmontwe is working on some of the foundations for future support of account pictures, once he is done with that there would be an opportunity to help on the image picker.

There are a few remaining issues left on this epic, are there any that are interesting to you? We might not have linked all the issues after the fact, so good to check functionality as well.

marcRDZ commented 10 hours ago

@kewisch count on it, I'll review the list to check possible candidates to tackle asap