search

thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11.05k stars 2.51k forks source link

Fix of "Title wraps within word in Improve the Experience screen" #8322

Closed shamim-emon closed 1 month ago

shamim-emon commented 1 month ago

Fixes #8257

shamim-emon commented 1 month ago

@cketti @wmontwe please let me know if I've missed anything. Thanks!

cketti commented 1 month ago

Thanks for your pull request :+1:

We have talked about this internally and decided on a path forward. Please see https://github.com/thunderbird/thunderbird-android/issues/8257#issuecomment-2413607685

I've created PR #8341 to switch to showing the brand name. Once that is merged it would be awesome if you could look into resizing the text so it fits the available width.

Side note: Please don't merge main into your pull request branch. If you want/need to update the pull request branch, rebase it on top of the updated main branch instead.

shamim-emon commented 1 month ago

Thanks for your pull request 👍

We have talked about this internally and decided on a path forward. Please see #8257 (comment)

I've created PR #8341 to switch to showing the brand name. Once that is merged it would be awesome if you could look into resizing the text so it fits the available width.

Side note: Please don't merge main into your pull request branch. If you want/need to update the pull request branch, rebase it on top of the updated main branch instead.

@cketti I have made corresponding text auto resizable so it always fits the available width. Please let me know if that's alright and/or if anything else needed.

shamim-emon commented 1 month ago

@cketti @wmontwe I was wondering if you guys were able to take a look? Did I miss something / anything else needed? Please let me know if anything more needs to be done from my end.

shamim-emon commented 1 month ago

@cketti @wmontwe all reviews are resolved + All checks have passed. If possible, please have a look and let me know if anything else required. Thanks in advance.

cketti commented 1 month ago

Thanks :+1: