search

thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11.05k stars 2.51k forks source link

Download attachment button has incorrect accessible name #8401

Closed dankeck closed 1 month ago

dankeck commented 1 month ago

Checklist

App

Thunderbird for Android

App version

8.0b4

Where did you get the app from?

Google Play

Android version

14

Device model

Pixel 5

Steps to reproduce

  1. Turn on the TalkBack screen reader.
  2. Open Thunderbird.
  3. Open an email message with an attachment.
  4. Navigate with TalkBack to an attachment's download button, which has an icon of a down arrow.

A button with an icon of a down arrow is indicated, under an image of the Thunderbird logo its file name and file size

Expected behavior

The download button is announced with an accurate name, like "download attachment".

Actual behavior

The download button is announced as "remove attachment".

Logs

No response

cketti commented 1 month ago

Thanks for the report.

The layout was copied from the message compose screen where the attachment box has a button to remove the attachment from the draft. The button on attachments in the message view screen allows users to save the attachment as an external file. I therefore went with "save attachment" as the content description (see #8404).