search

thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11.05k stars 2.51k forks source link

Encourage upgrading Thunderbird for QR code import #8410

Closed kewisch closed 1 month ago

kewisch commented 1 month ago

@cketti I give up, I can't believe it is so much extra work just to add a hyperlink. It looks like we'd need to have code that uses buildAnnotatedString with index positions to identify the hyperlink and then call openURI, which would make sense as a re-usable component.

Could you take a look at this one? I suspect it will be quick for you.

cketti commented 1 month ago

It's hard to make part of flowing text clickable while respecting the minimum size recommended to make it easy to tap using a finger. Presumably that's why there's no built-in support for that.

I'd recommend making the whole text clickable.

Default Finger down
image image

Would that work? I could update the PR accordingly.

kewisch commented 1 month ago

Yes I was thinking the same, making the whole text clickable but underlining and making the learn more text look like a hyperlink would be great.

Appreciate you taking over the pull request.

cketti commented 1 month ago

@kewisch: What's the URL for the link?

cketti commented 1 month ago

image