thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11.02k stars 2.51k forks source link

Inbox in french too long in left panel #8487

Open Tonus1 opened 2 weeks ago

Tonus1 commented 2 weeks ago

Checklist

App

Thunderbird for Android

App version

8.0b4

Where did you get the app from?

F-Droid

Android version

stock 13

Device model

No response

Steps to reproduce

  1. Open left panel while Inbox string is translated to something longer than Inbox

Expected behavior

Would be better to not wrap and have the end of text under the counters if it's more than 2 rows

Actual behavior

The Inbox in french is "Boîte de Réception" an shows up vertically. The string appears very long and hides other folders

Would be better to not wrap and have the end of text under the counters if it's more than 2 rows

Logs

Screenshot_20241104_084642_K-9 Mail

kewisch commented 2 weeks ago

That looks pretty weird, thanks for reporting. Let's see if we can get this fixed shortly.

kewisch commented 1 week ago

@wmontwe @cketti are there any other safeguards we can do on the code side that we could get into 8.2? I suspect localizations will need a bit to update.

cketti commented 1 week ago

We've added a comment for translators asking to keep the "99+" string as short as possible. I also uploaded a screenshot for translators so they can see where the string is used in the UI. Additionally, I marked some translations using long-ish strings as "needs editing" on Weblate.

cketti commented 1 week ago

We could limit the folder name to e.g. 2 lines max. That won't fix the issue of "missing" horizontal space. But it avoids list items growing to the whole height of the drawer.

kewisch commented 1 week ago

Would it be easily possible to wrap the 99+ and ★6 into two lines if the folder name is taking two lines?

cketti commented 1 week ago

This leads to weird edge cases. There can be a folder name that is long enough to require two lines when the unread count and starred count are displayed in one line, but not long enough that the folder name needs two lines when unread count and starred count are displayed in two lines. So no matter what strategy we pick, for such a folder, the name and unread/starred count will never occupy the same number of lines (unless we don't actually use the space freed up by breaking the unread/starred count).

Displaying the unread count and starred count at the same time never felt like a great idea to me. Instead, maybe we should think about adding a virtual folder for starred messages.