Fix of "QR code import does not update unified inbox"

thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)

https://thunderbird.net/mobile

Apache License 2.0

11.05k stars 2.51k forks source link

Fix of "QR code import does not update unified inbox" #8541

Closed shamim-emon closed 1 week ago

shamim-emon commented 2 weeks ago

Currently QR import doesn't update Unified inbox value to true if , after importing account , account number > 1(unless general setting is imported as-well. Incase of General Setting import, take Unified inbox value from general settings value instead) . This PR fixes the issue.
Fixes #8531

shamim-emon commented 1 week ago

SettingsImporterTest should be updated to test if UnifiedInboxConfigurator is called (only) when it should be called.

@cketti I've used mockito for added two tests mainly because, I'm not sure how to check UnifiedInboxConfigurator.configureUnifiedInbox() is being called or not without mocking it, as it's private property SettingsImporter.

Please let me know if that's alright . Thanks

shamim-emon commented 1 week ago

@cketti @wmontwe fixed the spotless issue. Please allow workflow trigger once more. Thanks in advance.