thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11.02k stars 2.51k forks source link

Not swiping when archive action is set #8575

Open shamim-emon opened 5 days ago

shamim-emon commented 5 days ago
kewisch commented 4 days ago

Do you have a screenshot on what this would look like? Would this action appear every time the users swipes? Telling users what is not working is incredibly difficult, I'm worried this might get in the way for users who intentionally didn't configure an archive folder but engage in a swipe.

I believe other clients will for example allow swiping a bit and then it stops, or allow configuring what should happen if the account doesn't support archiving (e.g. fall back to Trash if the user wants that).

shamim-emon commented 4 days ago

Do you have a screenshot on what this would look like? Would this action appear every time the users swipes? Telling users what is not working is incredibly difficult, I'm worried this might get in the way for users who intentionally didn't configure an archive folder but engage in a swipe.

I believe other clients will for example allow swiping a bit and then it stops, or allow configuring what should happen if the account doesn't support archiving (e.g. fall back to Trash if the user wants that).

@kewisch As screenshot might not provide the full insight on the update, providing a video instead. Please have a look and let me know your thought on this. Thanks. https://github.com/user-attachments/assets/43c4efb9-39b6-4da9-8f10-983152d00b27

kewisch commented 3 days ago

Thanks, much appreciated. I'm going to bring this up in the next design meeting and get back to you, should be later this week. I have some thoughts on how we could improve, but IANADesigner and would love an expert opinion.

shamim-emon commented 3 days ago

Thanks, much appreciated. I'm going to bring this up in the next design meeting and get back to you, should be later this week. I have some thoughts on how we could improve, but IANADesigner and would love an expert opinion.

Thank you, I will wait for the update on this. Just a question, could this be an alternative approach to this?

kewisch commented 3 days ago

It is worth considering, though there is a risk that people might intentionally not want an archive folder, and them accidentally taking this action would create it. On the other hand, I believe that is what happens on Desktop. Maybe we could even combine, e.g. a snackbar notification saying that there was no archive folder and it has been created, with an option to undo.

I'll bring this up in the meeting as well.

cketti commented 3 days ago

The app already asks users to configure special folders during account setup. We could add an option to create a folder there. We definitely should not create folders without asking the user.

shamim-emon commented 3 days ago

The app already asks users to configure special folders during account setup. We could add an option to create a folder there. We definitely should not create folders without asking the user.

The app already asks users to configure special folders during account setup. We could add an option to create a folder there. We definitely should not create folders without asking the user.

questions:

  1. Should this be under this issue? Or a new one?
  2. Do we need additional design for this or is it okay to create the additional UI based on existing look and feel on the onboarding/account creation flow?
cketti commented 3 days ago

Issues can be created by anyone and they can suggest arbitrary solutions. Please don't go ahead and start an implementation based on those suggestions. Even Philipp and I have only expressed our opinions in this thread. The team hasn't made a decision yet on how we want to handle this.