thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11.02k stars 2.51k forks source link

Syncing Unified Inbox updates all folders #8578

Open groszdaniel opened 4 days ago

groszdaniel commented 4 days ago

Checklist

App

Thunderbird for Android

App version

8.1

Where did you get the app from?

F-Droid

Android version

crDroid 10.8 GSI, based on Android 14

Device model

Xiaomi Redmi 9C NFC

Steps to reproduce

  1. Open Unified Inbox from the sidebar if you're not already there.
  2. Pull down to refresh.

Expected behavior

It updates only the folders that are included in the Unified Inbox. (Synchronizing one folder generally takes only takes a few seconds, and I only include Inbox, Sent mail and Drafts in the Unified Inbox, so it shouldn't take long.)

Actual behavior

It updates all folders, even ones that aren't included in the unified inbox, so it takes about a minute to complete. (I use GMail, and there are 7 standard folders and I have 15 tags, which appear as folders via IMAP.)

Having an option to synchronize all folders is useful, but we have the Synchronize button on the sidebar for that. I'd expect refreshing while viewing the Unified Inbox to only update those folders that need be up to date to show an up-to-date unified inbox.

Logs

No response

hwittenborn commented 2 days ago

Would it be ok for me to start working on this? I saw that the unconfirmed label was on it, but I'd be more than glad to add in the needed patch to make this work.

cketti commented 2 days ago

@hwittenborn: Thanks for offering :+1: We'd welcome help on this.

To add support for only checking the folders included in the unified inbox, please add a new method checkUnifiedInbox to MessagingController. However, the implementation itself should go into a separate file and use Kotlin. See DraftOperations for an example.

This part of the code base is quite old and not very intuitive. I expect you'll have quite a few questions. You can find us in the Thunderbird for Android developer room on Matrix: https://matrix.to/#/#tb-android-dev:mozilla.org