thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11.05k stars 2.51k forks source link

Fix Thunderbird release 8.1's versioncode #8609

Closed kazushi3 closed 1 hour ago

kazushi3 commented 3 hours ago

This changes TB 8.1's versioncode. 8.1's changelog is shown between 8.0b2 and 8.0b3 because it has incorrect versioncode.

kewisch commented 3 hours ago

It isn't that simple unfortunately. This was due to our release automation and merging not being 100% worked out. 8.1's version code is indeed 5, connected with the app net.thunderbird.android. The beta's versions are connected with the app net.thunderbird.android.beta.

I don't know how useful it would be to change the XML afterwards since the versions are already released. If we want to be verbose (and accurate) we could:

The other thing we could do is fall back to the version notes we prepared separately, which would be more in line with how automation works:

We were talking about this when we released 9.0b1, and decided to live with it for now, and do better in the future. If you still want to make a change, then the first approach would probably be closest to what is already visible in the notes.

kazushi3 commented 1 hour ago

Oh...

I understood this is not easy and team has already discussed. I don't think I have better solution. Thank you for your reply!

kewisch commented 1 hour ago

I appreciate you helping out though! If you want to check in on a few of our other issues, we have a few good first issues at https://github.com/thunderbird/thunderbird-android/issues/?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22 in case you'd like something more simple to get started, or your pick on issues from the list :)