search

thunderbird / thunderbird-notifications

In-App notifications for Thunderbird
Mozilla Public License 2.0
0 stars 1 forks source link

Conversion script should deal with missing properties in YAML files #23

Closed Sancus closed 1 month ago

Sancus commented 2 months ago

Right now, the YAML files appear to need every possible property specified, including empty lists for the include/exclude filters.

https://github.com/thunderbird/thunderbird-notifications/blob/main/yaml/example.yaml#L13

This makes the YAML difficult to edit and read, instead the conversion script should add empty values when outputting JSON for any properties that are required in the schema but aren't used in the YAML source.

radishmouse commented 1 month ago

Solved by using schema generated from pydantic model (#19). (PR coming shortly)

radishmouse commented 1 month ago

Closed by https://github.com/thunderbird/thunderbird-notifications/pull/28