thunderbird / thunderbird-notifications

In-App notifications for Thunderbird
Mozilla Public License 2.0
0 stars 1 forks source link

Feat/25 clean up workflow and schema #28

Closed radishmouse closed 1 month ago

radishmouse commented 1 month ago

Closes #18 #19 #23 #27 #24 #25

This PR:

radishmouse commented 1 month ago

@aaspinwall and @MelissaAutumn - The validate_json check fails because there is no existing json/notifications.json file. However, the convert_yaml_to_json check passes, creates the json/notifications.json, and subsequently runs the validate_json check.

Since there are no notifications, we can disregard the failing standalone validate_json check.

But also, I'm wondering: when exactly should we run the validate_json action? It is implicitly run via convert_yaml_to_json when:

When should we explicitly run validate_json? Currently, it runs on any pull request.

Sancus commented 1 month ago

General comment: There is still some 4-space indention in generate_json_schema.py but don't 2-space indent Python, it should always be 4. We probably ought to decide on a standard linter and rules for all of Python repos, something for later.

MelissaAutumn commented 1 month ago

General comment: There is still some 4-space indention in generate_json_schema.py but don't 2-space indent Python, it should always be 4. We probably ought to decide on a standard linter and rules for all of Python repos, something for later.

For most of our projects we have ruff setup and some settings setup. https://github.com/thunderbird/appointment/blob/main/backend/pyproject.toml#L66

I have setup in my ide to run on save and format. Works well!