thunderbird / thunderbird-website

Build code for the websites on thunderbird.net and start.thunderbird.net
https://www.thunderbird.net
142 stars 72 forks source link

New Donor Help Form #438

Closed MelissaAutumn closed 1 year ago

MelissaAutumn commented 1 year ago

Fixes #435

The embeddable HTML was a touch "auto-generated", so I've tried to cordon it off as much as possible. FA will only be loaded on our thunderbird.net/donate/help page (excluding custom styling).

There's a bunch of weird tag-along js/css that don't seem to be used but I'm slightly afraid of just removing it. (e.g. I don't even know if the localization js file is ever used..see the quirks below.)

I've already ditched their styling, and re-worked it into something passable for Thunderbird.net.

Once a user submits the form, they will be redirected to FA and then will be sent back to thunderbird.net/donate/help/thank-you. The text mirrors the existing Thunderbird specific text from donate-wagtail's help form https://donate.mozilla.org/en-CA/help/

Quirks:

Needs a style check, and there's some additional testing happening tomorrow. But it works!

Screenshots:

image Screen Shot 2023-05-17 at 15 43 25-fullpage

Mobile: image

MelissaAutumn commented 1 year ago

Cool, I have some style tweaks to make but will do after.

MelissaAutumn commented 1 year ago

Adjusted spacing, and colours. This is just pending another round of form testing on the Foundation side.

Screen Shot 2023-05-18 at 10 36 28-fullpage

MelissaAutumn commented 1 year ago

Merging this for staging testing. Functionality-wise it works as expected.

micahilbery commented 1 year ago

Sorry for not catching this sooner. My only criticism is the labels of the form elements feel a little detached from their fields when they aren't stacked. I would do something like this:

image

MelissaAutumn commented 1 year ago

Thanks @micahilbery I've created a new ticket to follow those changes, if you have anymore feel free to put them in https://github.com/thundernest/thunderbird-website/issues/442