search

thunderbird / thunderbird-website

Build code for the websites on thunderbird.net and start.thunderbird.net
https://www.thunderbird.net
136 stars 70 forks source link

Do not use autogenerated calendar for Japanese Holidays #468

Open kazushi3 opened 1 year ago

kazushi3 commented 1 year ago

I don't think autogenerated calendar works for Japanese. It contains too many events (not national holidays). For example, "バレンタイン", "七五三", and "七夕" are not holidays.

Which source are you using?

Sancus commented 1 year ago

https://calendarific.com/api-documentation

We currently include national, local, and "observance" holidays. We could probably consider excluding the latter. It's kind of a judgement call on whether people want dates that are not explicitly work holidays. I mean, I know バレンタイン is not a holiday in Canada either so I wouldn't mind having it on the calendar, but I know it's not a work holiday.

kazushi3 commented 1 year ago

I understand your idea. I think we need description about "observance" holidays.

And I found another problem in new calendar. Substitute holiday is missing.