search

thunderbird / thunderbird-website

Build code for the websites on thunderbird.net and start.thunderbird.net
https://www.thunderbird.net
148 stars 75 forks source link

Copy over a merchantid file required for Apple Pay during website build. #497

Closed MelissaAutumn closed 1 year ago

MelissaAutumn commented 1 year ago

Fixes #496

Sort of annoying that we have to host this file, so I just threw it in a misc folder. It gets copied to thunderbird.net/.well-known/<file name goes here> on build.

I also added a setting since it's an optional part of this site build but it does default to True.

Sancus commented 1 year ago

This is a one-time thing, afaik, so we can change the setting to False by default after the verification is done.

I'm not even sure if it's worth keeping this in the codebase, in the past I've just copied these types of files to the web servers manually(using Ansible) and then deleted them after pressing the verify button.

I suppose we may have to verify other subdomains in the future depending on what we do with the website structure.

Sancus commented 1 year ago

oh ffs

A registered domain’s verification expires when its SSL certificate expires.

MelissaAutumn commented 1 year ago

lol! Yea I think we'll need to keep this here sadly.

Sancus commented 1 year ago

I think this is good, I would add a comment in the settings file that turning that off will break Apple Pay donations, just so nobody ever turns it off unthinkingly.

Something like "Apple uses this to verify the domain every time the SSL cert expires, disabling will break Apple Pay donations."