thunderbird / thunderbird-website

Build code for the websites on thunderbird.net and start.thunderbird.net
https://www.thunderbird.net
133 stars 72 forks source link

Fix download button flashing, text resize flashing, and remove old donation stack js. #527

Closed MelissaAutumn closed 7 months ago

MelissaAutumn commented 7 months ago

Fixes #523

In order to prevent the download button flashing we need to force the browser to eval site.js before the first paint(?) occurs. What better way to do than force the site-bundle.js to download before any other assets? I've set common-bundle to defer, which seems to work okay.

After I fixed the download buttons, I noticed some text resizing issues with the rem measurement after a font loaded in. So swapped those out for their px equivalents.

EDIT: Actually this was caused by the max-inline-size using the ch measurement (size of the '0' glyph on the font.) I've adjusted it to an approx value in rem, and tested how it looks in a few locales. Seems fine.

Also removed the old donation js, and also the old unused donation server.

Sorry for the kitchen sink pr lol!