search

thunderbiscuit / devkit-wallet

A demo app for the bitcoindevkit on Android.
https://thunderbiscuit.github.io/devkit-wallet/
Apache License 2.0
28 stars 17 forks source link

Feat: Upgrading BDK to 0.7.0 #18

Closed fivetran-tangyetong closed 2 years ago

fivetran-tangyetong commented 2 years ago

Feat #13 Updated devkit to bdk-android 0.7.0 Fixed issue where blockchain was being created on every screen recomposition.

thunderbiscuit commented 2 years ago

This looks good to me. The only problem is that the Wallet.sync() method can be called without access to the network, which means the lateinit blockchain variable has not yet been instantiated, making the app crash.

I think a robust solution would probably include error handling and beefing up the sync() method, but I'd like to keep the app lean on those types of things which tend to obfuscate the simple version of using the API through the happy path so to speak.

What do you think of showing greyed out, unclickable buttons for sync, transaction history, and send if the network is not available?

network-unavailable

thunderbiscuit commented 2 years ago

If that sounds like an OK solution to ya I'll merge. Good stuff, thanks for the upgrade!