Addresses generated do not match expected addresses

thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.

https://padawanwallet.com/

Apache License 2.0

116 stars 50 forks source link

Addresses generated do not match expected addresses #14

Closed thunderbiscuit closed 3 years ago

thunderbiscuit commented 3 years ago

I assumed the default testnet address generation path was following BIP84, but the test addresses I'm generating do not match what I get on Ian Coleman's tool.

thunderbiscuit commented 3 years ago

Fixed with 82c598ff3679ddc25f9c9019b3c06c5af4cfc978!

The createDescriptor function was generating wpkh(keys.ext_priv_key/0/*) descriptors. It is now generating wpkh(keys.ext_priv_key/84'/1'/0'/1/*) descriptors, making it BIP84 compatible.