thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
116 stars 51 forks source link

removed hard-coded strings from IntroFragment.kt #158

Closed dhruv-1001 closed 2 years ago

dhruv-1001 commented 2 years ago

Fixes #155

Strings migrated to strings.xml as:

<string name="intro_dialog_message">...</string>
<string name="intro_dialog_title">...</string>
<string name="intro_dialog_positive">...</string>
<string name="intro_dialog_negative">...</string>
thunderbiscuit commented 2 years ago

Awesome! Thanks a bunch.

Just a quick fix: your commit message should follow the convention I'm using, which is:

  1. Start with a tag, capitalized (in your case Refactor:)
  2. Present-tense statement answering the question: "What does this commit do?", also capitalized

So for this one it would look something like this: Refactor: Move hard-coded strings from IntroFragment to strings.xml

Otherwise it's ready to merge!

thunderbiscuit commented 2 years ago

If you need help with fixing the message and force pushing to the PR let me know!

dhruv-1001 commented 2 years ago

Thanks for the suggestion, I hope it's alright now.

thunderbiscuit commented 2 years ago

Yep thanks for the contribution, and welcome to Padawan!