search

thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
116 stars 51 forks source link

Add confirmation message #160

Closed dhruv-1001 closed 2 years ago

dhruv-1001 commented 2 years ago

No confirmation message is shown on clicking "copy" TextView on Send Coins Back screen (SendCoinsBackFragment.kt). This might confuse users as no message confirms that they have successfully copied the address.

Screenshot for mentioned screen - Padawan_issue_image

thunderbiscuit commented 2 years ago

Good point. Thanks for adding the issue!

dhruv-1001 commented 2 years ago

I'll take on this issue. How should I handle this, through a toast?

thunderbiscuit commented 2 years ago

No I'm trying to remove reliance on toasts as they are deprecated. Snackbars is what I want to start using, but note that I had a hard time making it work previously for the "receive" tab. See #50. So not exactly sure how to make it work, but I imagine it should be not too hard.

fivetran-tangyetong commented 2 years ago

You can look at #161 for my solution for adding snackbars

dhruv-1001 commented 2 years ago

Issue solved.