Closed fivetran-tangyetong closed 2 years ago
I think this is good to go. Small little thing: usually I'm not a big fan of the not-null assertion operator. Are we sure this rootView can never be null?
I'll look into it and get back to you
Ok, I've changed intializing rootView
from container?.root
to simply calling binding.root
, which I should have done from the beginning. Thanks for pointing it out!
Good stuff.
Fixes #127 by calling a coroutine in the
onCreateView
so the view only calls it once on startup. Fixes #139 by calling the snackbar using therootView
instead of the child view, so switching fragments will not cause it to crash the app.