search

thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
116 stars 51 forks source link

Feature: Slight refactoring, adding more tests #174

Closed fivetran-tangyetong closed 2 years ago

fivetran-tangyetong commented 2 years ago

Renamed isSendTest to DatabaseUtilTest and added tests for netSendWithoutFees() Refacted the tests to be in their respective packages for easier readability in the future Added tests for Repository.kt

thunderbiscuit commented 2 years ago

I think some of this would be better as separate PRs (the APK generation deserves its own discussion, whereas some of the refactorings are easy to review/merge).

Do you mind removing the CI changes and opening a separate PR for that? The rest we can deal with in this PR.

fivetran-tangyetong commented 2 years ago

Updated the PR to the requested changes, is 2 commits fine or should I squash them into 1?

thunderbiscuit commented 2 years ago

In general I'm fine with as many as you need to be clear and structured (feel free to make PRs with much more than 2 commits if you're doing bigger work).

In this case however, because your second one is really just fixing up stuff from the first one, let's squash. I can do that on my end or you can squash/force-push if you prefer. Let me know. Otherwise this is ready for merge. Thanks for the work, that's good stuff! I'm really happy we got mockito in there now.