search

thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
114 stars 50 forks source link

Fix: Fixed the issue of app crashes due to lack of parent of snackbar… #190

Closed masterchief164 closed 2 years ago

masterchief164 commented 2 years ago

Fixed the issue of app crashes due to the nullability of the parent view in which snackbar is drawn. I just added null checks for the parent of the view before drawing a snackbar. Issue #187

thunderbiscuit commented 2 years ago

To be clear, I would take style refactoring PRs, but they'd need to be discussed beforehand just to make sure we make changes that are consistent.

thunderbiscuit commented 2 years ago

Small other comment: I'm trying to keep the commit messages close to or under 50 characters, with sentences using the present tense with the tag (thanks for applying the tag by the way). Here is what I'd put as commit message for this:

Fix: App crashes due to lack of parent of snackbar

Fixes #187

The last line (commit body) will close the issue #187 and keeps a link between the PR and the issue from a "meta" standpoint.

Thanks again for the fix!

thunderbiscuit commented 2 years ago

ACK 02bfd0cf264e7d5ed4b5f04168fb4dd8254a1724.