thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
116 stars 51 forks source link

App doesn't open unless connected to the Internet #208

Closed enyipreshious closed 1 year ago

enyipreshious commented 2 years ago

Padawan crushes if you try to open up the app without an internet connection

To reproduce this behaviour:

  1. Switch off your mobile data
  2. Click the app icon
  3. App crashes

A suggestion I think can make the experience better will be to give the user some form of error message on why the app can't open.

To make sure this wasn't only from my end. I tried it on another android phone(both android 11) and it gave the same result

fivetran-tangyetong commented 2 years ago

Good find, Ill work on the fix

thunderbiscuit commented 2 years ago

Yep good issue to point out! I'll add it to the milestone for the next release.

@darkvoid32 this issue will have a different fix depending on the bdk-android version we use; we should upgrade to bdk-android 0.6.0 first and fix from there (the API for bdk has changed a lot and we have decoupled the wallet and blockchain constructs, meaning you can now create a wallet without syncing whereas before you needed an initial ping to the Electrum server before creating the wallet (as outlined here and here on bdk-ffi.

fivetran-tangyetong commented 2 years ago

Related issues #194 , #192 . We will wait for the next BDK-ffi release for new wallet implementation to tackle this issue

fivetran-tangyetong commented 2 years ago

After migrating to bdk-android 0.7.0, we can create the blockchain when user gets internet connection, show snackbar with no internet connection sign etc..

thunderbiscuit commented 1 year ago

Finally done!