search

thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
113 stars 50 forks source link

Update README.md #251

Closed Prakhar-Agarwal-byte closed 1 year ago

Prakhar-Agarwal-byte commented 1 year ago

Update links to testnet faucets. Fixes #250

thunderbiscuit commented 1 year ago

The CI is failing but that's because of changes made in the 0.10.0 release. Haven't looked into it but let's open an issue to keep track of it and fix it.

thunderbiscuit commented 1 year ago

Actually would you mind amending the commit message?

In this case the tag applied would be Docs. So the message would be Docs: Update README.md. Otherwise this is ready to go.

Prakhar-Agarwal-byte commented 1 year ago

@thunderbiscuit I have ammended the commit message.

thunderbiscuit commented 1 year ago

Almost there! The tag is actually Docs, not Doc 😆. It's not a big thing but because those tags are meant for tools that would parse your commit history, typos will prevent the machine from properly finding them.

Also, would you mind squashing all of those into 1 commit? I don't want to assume your level of comfort with git so let me know if you'd like some pointers. Essentially I'm looking for 1, clean commit. You might need to do an interactive rebase to clean this up. This is the best article on interactive rebase I think.

thunderbiscuit commented 1 year ago

Perfect. Ready for merge.

thunderbiscuit commented 1 year ago

The GitHub UI is not picking up the fact that I merged this commit under a different hash. Closing now because it's been merged!