search

thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
113 stars 50 forks source link

Feat: Show sync status #254

Closed Prakhar-Agarwal-byte closed 1 year ago

Prakhar-Agarwal-byte commented 1 year ago

Fixes #252

Now the sync icon rotatation indicates that sync status.

https://user-images.githubusercontent.com/17739006/223063475-e0aa72a0-a44d-4557-80fa-9ad2f1def7f5.mp4

thunderbiscuit commented 1 year ago

@Prakhar-Agarwal-byte are you still working on this? If so you might need a quick rebase and small fixes, but otherwise looks good!

thunderbiscuit commented 1 year ago

Great stuff thanks for the work. I think we still have one small bug, but not sure if I should hold off the PR for it. The icon basically starts rotating backwards forever if you press the sync button many times really quickly. It's not really a problem for syncing (the functionality still works), but it's something in the animation. Take a look if you don't mind and see if you can reproduce it locally.

Don't spend too much effort if you can't fix it quickly, I think we can just open a new issue to keep track of it and fix it later on.

Prakhar-Agarwal-byte commented 1 year ago

I couldn't replicate the issue on my device. I repeatedly pressed the sync button quickly but the icon was rotating just fine.

https://user-images.githubusercontent.com/17739006/226995992-8e34d038-a5cb-4511-9168-14aadb7b9769.mp4