Added images of chapter 2 and implemented next up chapter button

thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.

https://padawanwallet.com/

Apache License 2.0

113 stars 50 forks source link

Added images of chapter 2 and implemented next up chapter button #270

Closed heisenberg01010 closed 1 year ago

heisenberg01010 commented 1 year ago

Completed the TODO of ChapterScreen.kt of adding chapter images in chapter2.
Added images of qr code and btc address.
Implemented the next up chapter button.
Next up: chapter button takes you to the chapter that is next to the selected chapter.

Question: should we implement the next up chapter button in a way that it takes us to the next chapter to the completed chapter?

Images in chapter 2	Next up button

thunderbiscuit commented 1 year ago

Hey thanks for the contribution!

So for the images, I'm actually trying to get a designer to build images and diagrams for us. So I'm not looking to add anything in those boxes just yet. Hopefully we can get a smooth and consistent look for all diagrams that way.

As for the next up button, what problem do you think it solves? I'm happy to consider it, but so far I feel like it might be more confusing than anything. If I want the next chapter... I feel like I would just click on it no? Let me know what you think.

heisenberg01010 commented 1 year ago

Hey thanks for the contribution!

So for the images, I'm actually trying to get a designer to build images and diagrams for us. So I'm not looking to add anything in those boxes just yet. Hopefully we can get a smooth and consistent look for all diagrams that way.

As for the next up button, what problem do you think it solves? I'm happy to consider it, but so far I feel like it might be more confusing than anything. If I want the next chapter... I feel like I would just click on it no? Let me know what you think.

Thanks for the feedback sir. Firstly, there was a Todo in the code to remember next up chapter so I interpreted it in this way, by adding a button. Moreover, if I am not wrong, in our app, we can't open the next chapter by simply clicking on it in the ChapterRootScreen, we can just see them on the card being selected. Currently, we have to click on a chapter in the card and then click on start chapter button to navigate to that chapter screen.

thunderbiscuit commented 1 year ago

The more I'm looking at this, the more I think the UX might be confusing. For example looking at the screenshot I was wondering: "What happens when I click on the "Next up: Chapter 3" button?" Does it open the chapter? Or does it just bring it up in the ChapterRootScreen so I can read the abstract?

thunderbiscuit commented 1 year ago

Thank you for looking into this @heisenberg01010. I think with some of the new design decisions this is not quite what I'm looking for however, so I'll be closing this PR.