thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
113 stars 50 forks source link

Fix navigation in learning and overriding text #271

Closed amar683 closed 1 year ago

amar683 commented 1 year ago

In the learning section, I notice two things 1) The text is overlaping over the task. WhatsApp Image 2023-03-20 at 18 16 03 2) After completing a chapter, the default chapter is always the first one, when we open the app and if we completed a chapter it stays on that chapter and button text also stays the same "Start chapter", while it should be pointed out to another chapter that need to be open. WhatsApp Image 2023-03-20 at 18 25 24 WhatsApp Image 2023-03-20 at 18 42 40 Solutions : for the first one instead of a text we should do like progress bar for every section, which shows how much the progress in perecentage, and whatever chapter is done instead of "Start chapter, we can write "Restart Chapter", which will be more convenient to user. After completing one chapter it should directly point to next chapter or section. Untitled (1) @thunderbiscuit Sir can you please assign this to me. Would love to work on this issue specially on the navigation one.

thunderbiscuit commented 1 year ago

I think this issue outlines 3 different things.

  1. For the padding issue and the overlap on small screens, this is being dealt with in PR #253. Feel free to review that and comment there if you think it could be improved!

  2. The change from "1 of 3" to a percentage is aesthetic only, and I'm not sure it adds much yet. It's something we could ask a designer about, but I'm not in a rush to make that change.

  3. Restart chapter is sort of the same. I'm not against the idea, but I don't know if it adds enough to be worth the change. Let me sit on it for a day or two, but I would say don't put too much effort into it just yet.