search

thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
111 stars 49 forks source link

Bug: Disable touch opacity when Bottom sheet is expanded. #284

Closed prateek-singh-3212 closed 11 months ago

prateek-singh-3212 commented 1 year ago

Issue We are currently not disabling the background touch opacity whenever the confirm transaction bottomsheet expands. This may leads to the Application crash. Adding the video for justification.

Reference

  1. Issue Description:

https://user-images.githubusercontent.com/76490368/229336343-1081ebd7-cdda-4c15-b865-6344bdb406f1.mp4

Possible Fix

  1. We can switch to the Modal bottom sheet which by default has the capability to disable the background touch opacity.
  2. We can use the pointerInput modifier in Scaffold to handle gestures. (Tried this and it has lots of edge cases).
prateek-singh-3212 commented 1 year ago

@thunderbiscuit I will pick this up. As I am working on filter transaction where I used the modal bottom sheet.

thunderbiscuit commented 1 year ago

Mmmm yes good point. Let me know what you find works best.