thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
111 stars 49 forks source link

Feature: Add share button in receive fragment #288

Closed guptasandeep7 closed 11 months ago

guptasandeep7 commented 1 year ago

In receive fragment, we can add share button so user can share their wallet address to others via message or any social media like (WhatsApp).

Below image is only for explanation. Please ignore the design ( I am not a UI/UX developer ).

share button

thunderbiscuit commented 1 year ago

I'm not opposed to this idea. Connected to #265.

Noyi-24-7 commented 1 year ago

Hmmmm, I like the idea, I'll try and whip up a flow and some designs 👍

amritakesh commented 1 year ago

WhatsApp Image 2023-04-05 at 21 45 23

why dont we add a copy option like here too?

thunderbiscuit commented 1 year ago

In this case the faucet address is not something users would need to share. It's mostly there to copy/paste into a transaction within the wallet (if a user doesn't have other addresses to send to). I think the simple copy button does the trick well for this use case.

Noyi-24-7 commented 1 year ago

True, that makes sense, also what if we change it to the copy icon, so we can drop it by the side, using the word and the plus icon, feels wonky, not a big deal, buh it would be a nice to have.

In this case the faucet address is not something users would need to share. It's mostly there to copy/paste into a transaction within the wallet (if a user doesn't have other addresses to send to). I think the simple copy button does the trick well for this use case.